Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation main screens skeleton #21

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Navigation main screens skeleton #21

merged 1 commit into from
Jul 31, 2024

Conversation

sdsantos
Copy link
Collaborator

@sdsantos sdsantos commented Jul 30, 2024

  • Implemented a bottom navigation bar
  • Added mostly empty screens for results, result and settings
  • Specified a pattern for navigation arguments
  • Enabled edge-to-edge on Android

Again the patterns specified are up for discussion. The main goal here was to have ViewModels do most of the work. And to avoid that Screens and ViewModels have instances of NavController, to keep them as simple as possible (again, great for testing).

Closes #15

@sdsantos sdsantos requested a review from aanorbel July 30, 2024 11:51
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@sdsantos sdsantos force-pushed the skeleton branch 2 times, most recently from 0de96bc to 14c7bea Compare July 31, 2024 15:43
@sdsantos sdsantos merged commit 3778278 into main Jul 31, 2024
6 checks passed
@sdsantos sdsantos deleted the skeleton branch July 31, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-platform tooling: Main Navigation skeleton
2 participants